bootstrap: add /dnsaddr nodes #4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Aug 7, 2017
ghost
commented
- Removes half of the static bootstrappers, and adds 4 /dnsaddr bootstrappers instead
- Updates go-libp2p for /dnsaddr support
- Updates go-libp2p-host because that was missed some time ago
ghost
added
Stebalien
reviewed
Aug 15, 2017
| @@ -14,23 +14,19 @@ import ( | |||
| // NOTE: This is here -- and not inside cmd/ipfs/init.go -- because of an | |||
| // import dependency issue. TODO: move this into a config/default/ package. | |||
| var DefaultBootstrapAddresses = []string{ | |||
| "/dnsaddr/bootstrap.libp2p.io/ipfs/QmNnooDu7bfjPFoTZYxMNLWUQJyrVwtbZg5gBMjTezGAJN", | |||
There was a problem hiding this comment.
Are these the correct ones? dig is giving me a different answer...
There was a problem hiding this comment.
I did not give you a different answer 😉
There was a problem hiding this comment.
; <<>> DiG 9.11.2 <<>> TXT _dnsaddr.bootstrap.libp2p.io
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 34286
;; flags: qr rd ra; QUERY: 1, ANSWER: 2, AUTHORITY: 0, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 65494
;; QUESTION SECTION:
;_dnsaddr.bootstrap.libp2p.io. IN TXT
;; ANSWER SECTION:
_dnsaddr.bootstrap.libp2p.io. 559 IN TXT "dnsaddr=/ip6/2a03:b0c0:0:1010::23:1001/tcp/4001/ipfs/QmSoLer265NRgSp2LA3dPaeykiS1J6DifTC88f5uVQKNAd"
_dnsaddr.bootstrap.libp2p.io. 559 IN TXT "dnsaddr=/ip4/178.62.158.247/tcp/4001/ipfs/QmSoLer265NRgSp2LA3dPaeykiS1J6DifTC88f5uVQKNAd"
;; Query time: 0 msec
;; SERVER: 127.0.0.53#53(127.0.0.53)
;; WHEN: Tue Aug 15 13:36:02 PDT 2017
;; MSG SIZE rcvd: 270
|
Yep the actual nodes and DNS records haven't been set up yet. I have the respective public/private keypairs sitting on disk here. |
whyrusleeping
approved these changes
Aug 15, 2017
|
This one is much easier to rebase, let's merge it after the circuit PR landed |
|
@lgierth the circuit pr landed
…On Wed, Aug 16, 2017, 7:01 PM Lars Gierth ***@***.***> wrote:
This one is much easier to rebase, let's merge it after the circuit PR
landed
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4127 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABL4HHtz-TKxq9-Az8Ws8as0HBmpD0Slks5sY58RgaJpZM4OvEsG>
.
|
License: MIT Signed-off-by: Lars Gierth <[email protected]>
ghost
force-pushed
the
feat/dns-bootstrap
branch
from
a3c506f
to
5689104
Compare
|
Jenkins now green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.