Fix error handling in commands add and get #4454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: keks <[email protected]>
ghost
assigned 
Stebalien
approved these changes
Dec 4, 2017
whyrusleeping
approved these changes
Dec 4, 2017
|
test failures appear unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4452.
When
SetErroris called in a command,res.Next()returns the error "received command error" makes the error set by the command available by callingres.Error(). To make handling these errors easier, the functionscmds.HandleErrorwas added. Unfortunately we forgot to use it in the get command.The add command did the right thing, but manually instead of calling HandleError. I made it call that function instead.