Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sharness docker #4489

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Fix sharness docker #4489

merged 3 commits into from
Dec 14, 2017

Conversation

Stebalien
Copy link
Member

  1. Set TERM to dumb.
  2. Strip any ANSI codes that make it into the docker output anyways.
  3. Don't use empty continuation lines.

(probably overkill but...)

@Stebalien
fix empty continuation line docker error
a7acb77 
I believe this is actually a bug in docker but it's easier to fix it ourselves
here.

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@Stebalien
strip ANSI sequences from docker build output
de02525 
sharness was failing because an ANSI reset sequence was getting inserted at the
beginning of the line.

License: MIT
Signed-off-by: Steven Allen <[email protected]>
@Stebalien
politely ask programs to not print ANSI codes by setting TERM to dumb
af21ae1 
License: MIT
Signed-off-by: Steven Allen <[email protected]>
@ghost ghost assigned Stebalien Dec 14, 2017
@ghost ghost added the status/in-progress In progress label Dec 14, 2017
@whyrusleeping whyrusleeping merged commit f29b1ff into master Dec 14, 2017
@ghost ghost removed the status/in-progress In progress label Dec 14, 2017
@whyrusleeping whyrusleeping deleted the fix/sharness-docker branch December 14, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @whyrusleeping