Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreapi: Pin API #4575

Merged
merged 4 commits into from
Feb 5, 2018
Merged

coreapi: Pin API #4575

merged 4 commits into from
Feb 5, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jan 10, 2018 •
edited
Loading

TODO:

  • Implement
  • Review
  • Docs
  • Tests

@ghost ghost assigned magik6k Jan 10, 2018
@ghost ghost added the status/in-progress In progress label Jan 10, 2018
@magik6k magik6k mentioned this pull request Jan 10, 2018
Open
51 tasks
@magik6k magik6k requested a review from a user January 12, 2018 03:14
frrist
frrist reviewed Jan 18, 2018
View reviewed changes
core/coreapi/pin_test.go
t.Error(err)
}

err = api.Pin().Add(ctx, p)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be verify the content was pined? e.g. list, err = api.Pin().Ls(ctx) && len(list) == 1 as is done elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of an example rather than a test, since this is tested a few times below I skipped that check here.

@whyrusleeping whyrusleeping mentioned this pull request Feb 1, 2018
Merged
@magik6k
coreapi: pin draft
064c194 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
coreapi: implement pin api
c8cfed5 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
coreapi: pin tests
5ea9a3c 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
coreapi: update after rebase
242c98f 
License: MIT
Signed-off-by: Łukasz Magiera <[email protected]>
@magik6k
Copy link
Member Author

magik6k commented Feb 4, 2018

Rebased

@whyrusleeping whyrusleeping merged commit 56509a7 into master Feb 5, 2018
@whyrusleeping whyrusleeping deleted the feat/coreapi/pin branch February 5, 2018 01:49
@ghost ghost removed the status/in-progress In progress label Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frrist frrist frrist approved these changes

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees

@magik6k magik6k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magik6k @whyrusleeping @frrist