Doc: golint-ify pin package #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Hector Sanjuan <[email protected]>
License: MIT Signed-off-by: Hector Sanjuan <[email protected]>
ghost
added
the
| @@ -141,19 +151,19 @@ type Pinner interface { | |||
| InternalPins() []*cid.Cid | |||
| } | |||
|
|
|||
| // Pinned represents CID which has been pinned with a pinning strategy. | |||
| // The Via field allows to identify the pinning parent of this CID, in the | |||
There was a problem hiding this comment.
Phrasing here is a bit weird "allows to identify"
whyrusleeping
approved these changes
Feb 13, 2018
|
@hsanjuan you're the best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all golint warnings in the
pinpackage.Due to stuttering, I had to rename
pin.PinModetopin.Mode. I can revert that specific commit though.Protobuf stuff not touched.