fixup DHT sharness tests #5114
Merged
fixup DHT sharness tests #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
added
need/review
|
Looks like something is making macs in jenkins really slow, https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/fix%2Ffix-dht-tests/2/pipeline/98/ didn't even fetch gx dependencies before timing out in 10 min. cc @victorbjelkholm |
|
@magik6k yeah, screensavers was somehow enabled again. Seems the last update installed itself and re-activated the screensavers. Deactivated again and now it's running OK. |
Stebalien
force-pushed
the
fix/fix-dht-tests
branch
from
aea0034
to
4bd18d0
Compare
|
@Stebalien update here? |
|
Jenkins keeps throwing a hissy fit. |
We can't currently put binary values due to API limitations. This worked before because the DHT wasn't checking values on local put. License: MIT Signed-off-by: Steven Allen <[email protected]>
see #5113 License: MIT Signed-off-by: Steven Allen <[email protected]>
Stebalien
force-pushed
the
fix/fix-dht-tests
branch
from
4bd18d0
to
384e2c4
Compare
|
@whyrusleeping jenkins is now happy. This could use a review but doesn't really need one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(in preparation for libp2p/go-libp2p-kad-dht#165)