fix two transport related bugs #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, enabling the QUIC transport will disable the default ones fixes #5416 License: MIT Signed-off-by: Steven Allen <[email protected]>
We explicitly setup listeners but we do this *after* constructing the node. fixes #5387 License: MIT Signed-off-by: Steven Allen <[email protected]>
ghost
assigned No reason not to and it would have caught #5416 License: MIT Signed-off-by: Steven Allen <[email protected]>
magik6k
approved these changes
Sep 1, 2018
|
Merging now to fix the bugs but we may want to think about libp2p/go-libp2p#409 a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see the commits)