Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unixfs): issue #5055 #5525

Merged
merged 1 commit into from
Sep 26, 2018
Merged

fix(unixfs): issue #5055 #5525

merged 1 commit into from
Sep 26, 2018

Conversation

overbool
Copy link
Contributor

Closes: #5055

License: MIT
Signed-off-by: Overbool [email protected]

License: MIT
Signed-off-by: Overbool <[email protected]>
@overbool
Copy link
Contributor Author

@Stebalien @schomatis could u help me review it?

@@ -14,7 +14,6 @@ import (
e "github.com/ipfs/go-ipfs/core/commands/e"
unixfs "gx/ipfs/QmU4x3742bvgfxJsByEDpBnifJqjJdV6x528co4hwKCn46/go-unixfs"
uio "gx/ipfs/QmU4x3742bvgfxJsByEDpBnifJqjJdV6x528co4hwKCn46/go-unixfs/io"
unixfspb "gx/ipfs/QmU4x3742bvgfxJsByEDpBnifJqjJdV6x528co4hwKCn46/go-unixfs/pb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @overbool !! Much cleaner!

@schomatis schomatis added the RFM label Sep 26, 2018
@Stebalien Stebalien merged commit 727bf49 into ipfs:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants