feat: warn user when 'pin remote add' while offline

[rukolahasser]

Resolves #8418

The warning is printed only when being online matters (if CID to be pinned remotely is in a local store)

[schomatis]

This seems be the correct way. My main ask at the moment would be to include a test for it in sharness (t0700-remotepin.sh), although I'm not sure how easy it is to deal with the situation that the command will still hang forever even after the warning (maybe we should add a timeout).

[rukolahasser]

@schomatis How do I set up the TEST_DOCKER_HOST? I tried running ipfs in docker locally and set the value to localhost, but it failed. Was I missing anything?

[schomatis]

Could you give me more context, please? What are you trying to do and why do you need TEST_DOCKER_HOST?

[rukolahasser]

This seems be the correct way. My main ask at the moment would be to include a test for it in sharness (t0700-remotepin.sh), although I'm not sure how easy it is to deal with the situation that the command will still hang forever even after the warning (maybe we should add a timeout).

I was trying to write a test for it as you mentioned above, and bootstrapped a rb-pinning-service-api with docker but the test still failed to run.

[schomatis]

I'm still not following completely without seeing the code but the idea is to put the test in sharness (in the file cited before), so Docker shouldn't be necessary for that.

[rukolahasser]

Turned out that I didn't have jq installed on my machine, now it's fixed. I've added a test and updated the PR, could you have a look please?

[rukolahasser]

Does everything look good in the PR? @schomatis

[schomatis]

Thanks for the ping, yes. Still we need to wait for lidel to confirm on #8418 (comment) to make sure if there is anything else needed.

[lidel]

LGTM, thank you.

• this saves people's time by warning them they forgot to start local provider
• interop test is unrelated, should be fixed by rebasing on after fix(ci): interop test parallelism #8674 lands

[lidel]

@rukolahasser mind rebasing this PR on top of the latest master ? It should fix the interop tests (we need CI to be green before we merge this)

[rukolahasser]

@lidel I rebased it but there was a failed test that seemed unrelated to my PR, was the failed test expected?

[lidel]

Thank you, this LGTM. (Pushed small fix to ensure output of --enc=json is not impacted)

CI issue was unrelated, all green now.