Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(logging): environment variables with per-subsystem details #8833

Merged
merged 2 commits into from
Apr 6, 2022
Merged

docs(logging): environment variables with per-subsystem details #8833

merged 2 commits into from
Apr 6, 2022

Conversation

justindotpub
Copy link
Contributor

Document IPFS_LOGGING deprecation as alias to GOLOG_LOG_LEVEL and expand doc to include per-subsystem log levels.

@justindotpub justindotpub changed the title docs: environment-variables.md docs: IPFS_LOGGING, GOLOG_LOG_LEVEL environment variable, with per-subsystem details Mar 30, 2022
docs: environment-variables.md
9a096d6 
Document IPFS_LOGGING deprecation as alias to GOLOG_LOG_LEVEL and expand doc to include per-subsystem log levels.
lidel
lidel requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mind adding the same deprecation note for IPFS_LOGGING_FMT ?

@lidel lidel changed the title docs: IPFS_LOGGING, GOLOG_LOG_LEVEL environment variable, with per-subsystem details docs: logging environment variables with per-subsystem details Mar 31, 2022
Kubuxu
Kubuxu approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@Kubuxu Kubuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidel lidel changed the title docs: logging environment variables with per-subsystem details docs(logging): environment variables with per-subsystem details Mar 31, 2022
@justindotpub
Copy link
Contributor Author

Thanks! Mind adding the same deprecation note for IPFS_LOGGING_FMT ?

Done. 👍

@justindotpub justindotpub requested a review from lidel March 31, 2022 01:15
@BigLep BigLep added this to the Best Effort Track milestone Mar 31, 2022
@lidel lidel merged commit 7b2c7c7 into ipfs:master Apr 6, 2022
@justindotpub justindotpub deleted the justincjohnson/doc-update branch April 6, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Kubuxu approved these changes

@lidel lidel lidel approved these changes

Assignees

@justindotpub justindotpub

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
Best Effort Track
Development

Successfully merging this pull request may close these issues.
4 participants
@justindotpub @lidel @Kubuxu @BigLep