Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to new cbor lib #29

Closed
whyrusleeping opened this issue Oct 5, 2017 · 7 comments
Closed

migrate to new cbor lib #29

whyrusleeping opened this issue Oct 5, 2017 · 7 comments
Labels
P0 Critical: Tackled by core team ASAP

Comments

@whyrusleeping
Copy link
Member

We should use https://github.com/polydawn/refmt, it was designed with a lot of our usecases in mind

@magik6k
Copy link
Member

magik6k commented Oct 6, 2017

This lib could be also used for serialization of dagNodes (currently ipld modules are hard-coded with MarshalJson)

cc @Stebalien

@Stebalien
Copy link
Member

Stebalien commented Oct 6, 2017

Missing pieces:

@whyrusleeping whyrusleeping added P0 Critical: Tackled by core team ASAP status/ready Ready to be worked labels Oct 17, 2017
@dignifiedquire dignifiedquire mentioned this issue Nov 13, 2017
6 tasks
@Stebalien
Copy link
Member

Note: some quick benchmarking shows that the current library is slightly faster (especially when decoding). However, that may change when decoding/encoding directly to a datastructure rather than an object.

@phritz
Copy link

phritz commented Sep 11, 2018

Checking on status here. This is still WIP?

@Stebalien
Copy link
Member

Yes but it's getting close. I need to review and merge some CID changes (so we'll always just use cid.Cid instead of *cid.Cid). Then, we'll need to update the refmt version here and we should be good to go.

@dignifiedquire
Copy link
Member

dignifiedquire commented Sep 11, 2018 via email

@Stebalien
Copy link
Member

Done.

@ghost ghost removed the status/ready Ready to be worked label Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

5 participants