chore: make gocritic happier

Solve most results of:
```console
$ gocritic check ./... 2>&1 | grep -v "_test\.go:"
```

bitswap/client/internal/session/session.go

@@ -483,7 +483,7 @@ func (s *Session) resetIdleTick() {
 		avLat := s.latencyTrkr.averageLatency()
 		tickDelay = s.baseTickDelay + (3 * avLat)
 	}
-	tickDelay = tickDelay * time.Duration(1+s.consecutiveTicks)
+	tickDelay *= time.Duration(1 + s.consecutiveTicks)
 	s.idleTick.Reset(tickDelay)
 }
 

bitswap/client/internal/session/sessionwantsender.go

@@ -653,11 +653,12 @@ func (sws *sessionWantSender) updateWantBlockPresence(c cid.Cid, p peer.ID) {
 
 	// If the peer sent us a HAVE or DONT_HAVE for the cid, adjust the
 	// block presence for the peer / cid combination
-	if sws.bpm.PeerHasBlock(p, c) {
+	switch {
+	case sws.bpm.PeerHasBlock(p, c):
 		wi.setPeerBlockPresence(p, BPHave)
-	} else if sws.bpm.PeerDoesNotHaveBlock(p, c) {
+	case sws.bpm.PeerDoesNotHaveBlock(p, c):
 		wi.setPeerBlockPresence(p, BPDontHave)
-	} else {
+	default:
 		wi.setPeerBlockPresence(p, BPUnknown)
 	}
 }

bitswap/decision/forward.go

@@ -3,10 +3,10 @@ package decision
 import "github.com/ipfs/go-libipfs/bitswap/server"
 
 type (
-	// DEPRECATED use server.Receipt instead
+	// Deprecated: use server.Receipt instead
 	Receipt = server.Receipt
-	// DEPRECATED use server.ScoreLedger instead
+	// Deprecated: use server.ScoreLedger instead
 	ScoreLedger = server.ScoreLedger
-	// DEPRECATED use server.ScorePeerFunc instead
+	// Deprecated: use server.ScorePeerFunc instead
 	ScorePeerFunc = server.ScorePeerFunc
 )

bitswap/message/pb/cid.go

@@ -40,5 +40,5 @@ func (c *Cid) UnmarshalJSON(data []byte) error {
 }
 
 func (c Cid) Equal(other Cid) bool {
-	return c.Cid.Equals(c.Cid)
+	return c.Cid.Equals(other.Cid)
 }

bitswap/wantlist/forward.go

@@ -6,18 +6,18 @@ import (
 )
 
 type (
-	// DEPRECATED use wantlist.Entry instead
+	// Deprecated: use wantlist.Entry instead
 	Entry = wantlist.Entry
-	// DEPRECATED use wantlist.Wantlist instead
+	// Deprecated: use wantlist.Wantlist instead
 	Wantlist = wantlist.Wantlist
 )
 
-// DEPRECATED use wantlist.New instead
+// Deprecated: use wantlist.New instead
 func New() *Wantlist {
 	return wantlist.New()
 }
 
-// DEPRECATED use wantlist.NewRefEntry instead
+// Deprecated: use wantlist.NewRefEntry instead
 func NewRefEntry(c cid.Cid, p int32) Entry {
 	return wantlist.NewRefEntry(c, p)
 }

files/multifilereader.go

@@ -130,8 +130,7 @@ func (mfr *MultiFileReader) Read(buf []byte) (written int, err error) {
 	}
 
 	// otherwise, read from file data
-	switch f := mfr.currentFile.(type) {
-	case File:
+	if f, ok := mfr.currentFile.(File); ok {
 		written, err = f.Read(buf)
 		if err != io.EOF {
 			return written, err

files/serialfile.go

@@ -140,7 +140,7 @@ func (f *serialFile) Stat() os.FileInfo {
 
 func (f *serialFile) Size() (int64, error) {
 	if !f.stat.IsDir() {
-		//something went terribly, terribly wrong
+		// something went terribly, terribly wrong
 		return 0, errors.New("serialFile is not a directory")
 	}
 

gateway/handler.go

@@ -563,17 +563,18 @@ func webRequestError(w http.ResponseWriter, err *requestError) {
 }
 
 func webError(w http.ResponseWriter, err error, defaultCode int) {
-	if errors.Is(err, path.ErrInvalidPath{}) {
+	switch {
+	case errors.Is(err, path.ErrInvalidPath{}):
 		webErrorWithCode(w, err, http.StatusBadRequest)
-	} else if isErrNotFound(err) {
+	case isErrNotFound(err):
 		webErrorWithCode(w, err, http.StatusNotFound)
-	} else if errors.Is(err, ErrGatewayTimeout) {
+	case errors.Is(err, ErrGatewayTimeout):
 		webErrorWithCode(w, err, http.StatusGatewayTimeout)
-	} else if errors.Is(err, ErrBadGateway) {
+	case errors.Is(err, ErrBadGateway):
 		webErrorWithCode(w, err, http.StatusBadGateway)
-	} else if errors.Is(err, context.DeadlineExceeded) || err == context.DeadlineExceeded {
+	case errors.Is(err, context.DeadlineExceeded):
 		webErrorWithCode(w, err, http.StatusGatewayTimeout)
-	} else {
+	default:
 		webErrorWithCode(w, err, defaultCode)
 	}
 }