Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@helia/* modules should throw readable errors if CIDs with mismatched codecs are passed #377

Open
achingbrain opened this issue Jan 11, 2024 · 0 comments · May be fixed by #643
Open

@helia/* modules should throw readable errors if CIDs with mismatched codecs are passed #377

achingbrain opened this issue Jan 11, 2024 · 0 comments · May be fixed by #643

Comments

@achingbrain
Copy link
Member

E.g. a CID suitable for use with @helia/json has the .code value 0x200 - if a CID without this codec is passed to @helia/json.get it should error saying something like:

The passed CID had an incorrect codec, it may correspond to a non-JSON block
@tabcat tabcat linked a pull request Oct 3, 2024 that will close this issue
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Helia Working Group (inactive)
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: @helia/* modules validate CID codec tabcat/helia
1 participant
@achingbrain