Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate ACL for window.ipfs on IPFS paths (assume HTTP gateway) #375

Closed
lidel opened this issue Feb 7, 2018 · 0 comments · Fixed by #386
Closed

Isolate ACL for window.ipfs on IPFS paths (assume HTTP gateway) #375

lidel opened this issue Feb 7, 2018 · 0 comments · Fixed by #386
Assignees
@alanshaw
Labels
topic/security Work related to security

Comments

@lidel
Copy link
Member

lidel commented Feb 7, 2018

As noted by @victorbjelkholm in #362 (comment):

The address for checking the permissions needs to be the full path, but without the hash and query parameters. Otherwise applications running on a gateway gets access to other apps running on the same gateway.

(adding as separate issue so we don't forget about it)
@lidel lidel added the topic/security Work related to security label Feb 7, 2018
This was referenced Feb 8, 2018
Closed
Closed
@alanshaw alanshaw self-assigned this Feb 12, 2018
@alanshaw alanshaw mentioned this issue Feb 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanshaw alanshaw

Labels
topic/security Work related to security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds scoped permissions tableflip/ipfs-companion
2 participants
@alanshaw @lidel