Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display IPFS addresses instead of opening uploaded file #423

Closed
lidel opened this issue Mar 14, 2018 · 2 comments
Closed

Display IPFS addresses instead of opening uploaded file #423

lidel opened this issue Mar 14, 2018 · 2 comments
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Mar 14, 2018

Part of UX improvements for sharing local files (#342)

Current Behaviour

  1. user opens Upload Screen via browserAction
  2. user uploads a file (eg. image)
  3. upload is successful
  4. upload tab is closed (automatically)
  5. uploaded file is opened from IPFS address in a new tab (automatically)

This works fine for things like images and videos, but try uploading .zip file 🙃
The browser will display "Save file as..." monit and start download in background. This is very painful if user uploaded huge file, and quite annoying if all user wants is to copy shareable link.
(solved in #349)

Expected Behaviour

  1. user opens Upload Screen via browserAction
  2. user uploads a file (eg. image)
  3. upload is successful
  4. we stay on the Upload Screen
    it gets updated and presents new items to the user:
    1. Original name(s) of uploaded file(s)
    2. Canonical IPFS path
    3. Shareable URL at public gateway (which user can already customize via Preferences)
    4. "Drop / Upload Another File"

The old behaviour will be just one click away,
but we solve some pressing issues:

  • mobile connections with data cap will not charge user twice
  • sharing IPFS links to binary files gets a lot easier

Additional Improvements

  1. Display indicator of health (peer count of each file obtained via ipfs dht findprovs)
    (ipfs dht findprovs QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR -n 2, then -n 3 etc)
  2. A short disclaimer informing uploader/receiver that public gateway does not guarantee availability of content after X hours

(see ipfs/ipfs-gui#34 (comment) for more detailed list)

@lidel lidel added help wanted Seeking public contribution on this issue UX exp/intermediate Prior experience is likely helpful labels Mar 14, 2018
@lidel
Copy link
Member Author

lidel commented Mar 17, 2018

Design aspect of this is currently tracked in ipfs/ipfs-gui#34
There is also a PoC standalone app: https://github.com/tableflip/share-via-ipfs


Q3 2018 Update:

@lidel lidel added the status/ready Ready to be worked label Jun 25, 2018
@lidel
Copy link
Member Author

lidel commented Dec 24, 2019

Closed in v2.10.0 by opening imported file in Web UI's Files interface: #810

@lidel lidel closed this as completed Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

1 participant