Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in IPFS config property Discovery.MDNS.Enabled #1631

Closed
olizilla opened this issue Sep 8, 2020 · 2 comments · Fixed by #1632
Closed

Typo in IPFS config property Discovery.MDNS.Enabled #1631

olizilla opened this issue Sep 8, 2020 · 2 comments · Fixed by #1632
Assignees
@rafaelramalho19
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@olizilla
Copy link
Member

olizilla commented Sep 8, 2020 •
edited
Loading

Enabled should start with a capital E in Discovery.MDNS.Enabled, as per https://github.com/ipfs/go-ipfs/blob/master/docs/config.md#discoverymdnsenabled

Currently ipfs-desktop sets the property name to be enabled
https://github.com/ipfs-shipyard/ipfs-desktop/blob/c387c4f4b2acd2cdc616cc326a9bbfb092d1c3da/src/daemon/config.js#L55

as discovered by @daviddias

image(3)
@olizilla olizilla added the need/triage Needs initial labeling and prioritization label Sep 8, 2020
@jessicaschilling
Copy link
Contributor

@rafaelramalho19 and/or @lidel, please have a look if we want to prioritize this above the weekly triage. Thanks!

@rafaelramalho19 rafaelramalho19 self-assigned this Sep 8, 2020
@rafaelramalho19 rafaelramalho19 added kind/bug A bug in existing code (including security flaws) and removed need/triage Needs initial labeling and prioritization labels Sep 8, 2020
@rafaelramalho19
Copy link
Contributor

Thanks for opening the issue @olizilla, will address this now

@rafaelramalho19 rafaelramalho19 mentioned this issue Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaelramalho19 rafaelramalho19

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: uppercase Discovery.MDNS.enabled in default config ipfs/ipfs-desktop
3 participants
@olizilla @jessicaschilling @rafaelramalho19