Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI and Desktop languages #844

Closed
hacdias opened this issue Feb 26, 2019 · 9 comments
Closed

Web UI and Desktop languages #844

hacdias opened this issue Feb 26, 2019 · 9 comments
Assignees
Labels
P2 Medium: Good to have, but can wait until someone steps up

Comments

@hacdias
Copy link
Member

hacdias commented Feb 26, 2019

Right now, Desktop gets its language from the operating system its running on and passes it to the Web UI. Although, the user can change the language of the Web UI via its Settings, which does not affect the language of IPFS Desktop and then we get a mixed UI.

I've got some possible options to solve this issue:

Option Pros Cons
Change Desktop's language according to Web UI's Easy to find on settings and simple for the user We can't make sure if there are the same languages for both the Web UI and Desktop
Hide the language option on Web UI and just use the OS language No problems whatsoever The user can't pick a different language
Create some kind of menu that is smart and knows the available languages for both Web UI and Desktop and only shows the ones that exist for both Works best More work, but feasible I think. Harder to keep up to date with all translations.

@olizilla @fsdiogo @lidel what do you think?

@lidel
Copy link
Member

lidel commented Feb 26, 2019

Depends who is the target audience. I believe the goal is to encourage contributing missing translations, so we should not be hiding them. We crowdsource translations from community. To get to translation parity between Web UI and Desktop we should surface missing translations, so potential contributors see what is missing.

I'd go with low hanging fruit: "Change Desktop's language according to Web UI's".
If desktop is missing language selected in Web UI, it should fallback to English strings.

If we want to go extra mile, Desktop could also display a message asking user if they would like to contribute missing translation, clicking Yes would redirect them to https://www.transifex.com/ipfs/ipfs-desktop/)

@hacdias
Copy link
Member Author

hacdias commented Feb 27, 2019

First part is done, we now need to drive the extra mile.

Desktop could also display a message asking user if they would like to contribute missing translation, clicking Yes would redirect them to transifex.com/ipfs/ipfs-desktop)

@hacdias hacdias self-assigned this Jul 24, 2019
@hacdias hacdias added the P2 Medium: Good to have, but can wait until someone steps up label Jul 24, 2019
@hacdias
Copy link
Member Author

hacdias commented Apr 24, 2020

This is something trivial to do. @lidel @jessicaschilling do you think this is still useful?

@jessicaschilling
Copy link
Contributor

Yes!

@hacdias
Copy link
Member Author

hacdias commented Apr 24, 2020

Maybe a dialog when a person opens IPFS Desktop for the first time and then leaving a button on the menu to contribute (maybe under About)?

@jessicaschilling
Copy link
Contributor

Only for folks for whom their chosen WebUI language doesn't exist in Desktop, right? If so, that sounds good.

@hacdias
Copy link
Member Author

hacdias commented Apr 24, 2020

Uh, I get it now and it may be more complicated than what I thought then. I'll investigate, but it is certainly possible.

@lidel
Copy link
Member

lidel commented Apr 27, 2020

I think #847 + #1447 are good enough to close this issue. 😬

I am worried anything more will be diminishing returns, or even cause harm (displaying popups to a new user that just installed the app may be annoying).

@jessicaschilling
Copy link
Contributor

Makes sense to me. We can always revisit if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

3 participants