-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show pins, add pins and browse the whole universe #1025
Comments
Yes, I want to show a page above the MFS root, that lists out yout pins, and some interesting CIDs, so you can see things in the blockstore that aren't in the MFS, and parhaps a way to |
This comment has been minimized.
This comment has been minimized.
@olizilla so what would the structure of the root be? I did thought about something like this:
|
Some questions for things to decide:
|
This might be out of scope and perhaps should be moved to another issue: I noticed the files page is being re-rendered like crazy for no reason. I've also noticed that we could really simplify our code if we kept most of the action code and state on the redux bundle. That way, we could connect each component to the specific bits of data they need, simplifying the code. And since it would be a "shared" state, it could help us with functionalities that involve the selected files, for instance. I could refactor the code, and in the meanwhile introduce this change. I don't know how much time it'd take, but certainly a bit. It'd also produce a really big PR even though I'd basically use all the current components just as they are. /cc @olizilla |
In general it's better to keep new features and refactors as seperate tasks. Let's make that a seperate issue. For the "what should we show where" the goals are:
So, when you click on the files tab, ideally we'd show a few of your most recently pinned CIDs and the current CID for the MFS root, that you could click through to. Alas, we don't have a way to get "recent pins"... it's all or nothing. We could get the full list and show it as a count like "58 blocks pinned / 2988 blocks stored", along with a link to list the recursively pinned root CIDS... We could also change the "expore a CID" feature to show a preview of the content along with a little metadata, rather than have it open things in the IPLD explorer... In general I think folks will probably want to see the things rather than see the IPLD data behind the things. We could show /ipfs and /ipns as special folders inside your MFS... but it's weird. With an empty MFS, the root dir would have the CID of the empty dir |
Some ideas taken from a call today with @olizilla:
Oli also had an idea to let users browse the blocks (could you give more details on that one?). Another interesting topic that came in mind is to update the main bar at the top (Explore) to Browse so it opens IPFS paths on Files page instead of explore page by default. This thoughts need to be improved. In the meanwhile, you can take a look at #1027. It already lets you browse any files you want ( Ideas for the navigation breadcrumbs (we'd still need a way to get back to MFS when viewing IPNS/IPFS): Ideas for the right side actions: |
Agreed. On pins page, perhaps a 'Pin' button and also add the 'Pin' option to the drop down. We will be able to navigate any files we want :O |
@hacdias i'm currently distracted with camp design, but maybe this design which i began in collab with @olizilla can help advance the conversation. To be cont |
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
It would be interesting if we could show the user pinned pins (yeah!) on the Files section inside the Web UI. I imagine it as special folder with different icon and some explanation.
It'd be a read-only folder and would only be shown to users that have one or more recursive (and direct?) pins. The folder would allow to navigate the pinned directories/files.
It wouldn't, of course, show indirect pins.
Describe alternatives you've considered
Use the CLI. I'm thinking about something visual.
Additional context
N/A
Closes ipfs/ipfs-desktop#922.
The text was updated successfully, but these errors were encountered: