Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files screen: add pinning option to bottom bar when multiple files selected #1682

Open
jessicaschilling opened this issue Oct 28, 2020 · 3 comments
Labels
area/pinning Integrating pinning into GUI apps area/screen/files Issues related to Files screen effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/design-front-end Front-end implementation of UX/UI work

Comments

@jessicaschilling
Copy link
Contributor

The third and fourth panes in the pinning service integration Files screen mockups depict a workflow for setting pinning on multiple files. However, this was de-scoped from pinning integration MVP due to unexpected complexity (orig #1500 (comment)):

  • when user selects multiple items a bottom drawer is displayed with operations that could be applied to all of them
    • Q: should we support bulk pin control when multiple files are selected this way?
    • A: we could, but not in scope for MVP.
      • Rationale: this is additional work which needs more thought. We could either:
        • pin each selected item separately,
        • or we could follow logic used by Share action and create ephemeral directory that contains selected items and only pin the root CID

This issue exists to isolate and implement that work at a later date.
cc @rafaelramalho19 @lidel

Related request from @Tcll to implement, regardless of pinning services: #1681

@jessicaschilling jessicaschilling added area/pinning Integrating pinning into GUI apps area/screen/files Issues related to Files screen exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/design-front-end Front-end implementation of UX/UI work labels Oct 28, 2020
@lidel
Copy link
Member

lidel commented Nov 10, 2020

Quick feedback after playing with stage 1 (#1685) implementation:

  • I believe we should pin each selected item separately

Rationale: the way we will do remote pin status check is to:

  1. check if file is pinned
  2. check if any of its parent directories is pinned

👉 due to this, we can't do what we do for Share (create ephemeral directory with selected files and only pin the directory's CID). That would make it impossible to detect remote pin.

Just for reference, below is current UI from #1685 (i forced pinning modal via context m,enu on a single file, thus different file size – ignore it, i made screenshot for something else).

For MVP we should enable Set pinning option and make it issue ipfs.pin.remote.add call for each CID separately.

2020-11-06--21-32-35

@jessicaschilling
Copy link
Contributor Author

Makes sense, and probably hews closest to most user's mental model of how this would actually work anyway - the ephemeral directory thing is a bit hard to wrap one's head around if you're thinking within the context of other ordinary file systems.

@lidel lidel added this to the v2.13 milestone Apr 14, 2021
@lidel lidel modified the milestones: v2.13, v2.14 Jan 17, 2022
@SgtPooki
Copy link
Member

SgtPooki commented Dec 2, 2022

need to confirm whether this was already addressed by #1919

@SgtPooki SgtPooki removed this from the v2.14 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pinning Integrating pinning into GUI apps area/screen/files Issues related to Files screen effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/design-front-end Front-end implementation of UX/UI work
Projects
No open projects
Status: Planned / Backlog
Development

No branches or pull requests

3 participants