fix: import status window UX #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelramalho19
temporarily deployed
to
Deploy
GitHub Actions
Inactive
|
The demo looks great! Thanks so much for throwing this together. I'm going to check out the code now. |
SgtPooki
approved these changes
Jan 11, 2023
| @@ -11,7 +11,7 @@ button:not(.disabled) { | |||
| cursor: pointer; | |||
| } | |||
|
|
|||
| button:not(.default):focus { | |||
| button:not(.default):focus-visible { | |||
There was a problem hiding this comment.
there is some (very-light) lack of browser support here, though greenfield browsers seem to support it fine. focus-visible is generally accepted as a better replacement.
https://caniuse.com/?search=focus-visible vs https://caniuse.com/mdn-css_selectors_focus
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Jan 27, 2023
## [2.22.0](v2.21.0...v2.22.0) (2023-01-27) CID `bafybeifeqt7mvxaniphyu2i3qhovjaf3sayooxbh5enfdqtiehxjv2ldte` --- ### Features * different countly keys for kubo and webui.ipfs.io deployments ([#2081](#2081)) ([2e766fa](2e766fa)) ### Bug Fixes * import status window UX ([#2075](#2075)) ([4104cc6](4104cc6)) * webui update metrics to opt-out by default (part of 2074) ([#2084](#2084)) ([cac7663](cac7663)) ### Trivial Changes * pull new translations ([#2076](#2076)) ([ad9e4ff](ad9e4ff))
|
🎉 This PR is included in version 2.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2030
Demo
(1st part of the demo is with mouse clicks, 2nd is with the keyboard navigation for accessibility)
webui-popup-ux.mov
Potential side-effects
src/reset.cssto use:focus-visibleinstead of:focus, which makes the outline box around "tabbable" elements only appear with KEYBOARD and not MOUSE interactions.