From 851114481bac91a745d819c1afd55c36c2b71315 Mon Sep 17 00:00:00 2001 From: Henrique Dias Date: Tue, 9 Aug 2022 09:27:08 +0200 Subject: [PATCH 1/3] fix: remove web ui version and keep revision --- src/navigation/NavBar.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/navigation/NavBar.js b/src/navigation/NavBar.js index 3e09a1cc0..a34209f8f 100644 --- a/src/navigation/NavBar.js +++ b/src/navigation/NavBar.js @@ -55,8 +55,6 @@ export const NavBar = ({ t }) => { const bugsUrl = `${codeUrl}/issues` const gitRevision = process.env.REACT_APP_GIT_REV const revisionUrl = `${codeUrl}/commit/${gitRevision}` - const webUiVersion = process.env.REACT_APP_VERSION - const webUiVersionUrl = `${codeUrl}/releases/tag/v${webUiVersion}` return (
@@ -75,9 +73,6 @@ export const NavBar = ({ t }) => {
- { webUiVersion &&
- {t('app:terms.ui')} v{webUiVersion} -
} { gitRevision &&
{t('app:nav.revision')} {gitRevision}
} From 0b663703a16d8f27b5fb2474f323604e2ab5731d Mon Sep 17 00:00:00 2001 From: Henrique Dias Date: Tue, 9 Aug 2022 14:16:48 +0200 Subject: [PATCH 2/3] fix: replace web ui version by revision in status page --- public/locales/en/app.json | 6 +++--- src/navigation/NavBar.js | 2 +- src/status/NodeInfo.js | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/public/locales/en/app.json b/public/locales/en/app.json index 25dec68db..ddba598c3 100644 --- a/public/locales/en/app.json +++ b/public/locales/en/app.json @@ -37,8 +37,7 @@ }, "nav": { "bugsLink": "Report a bug", - "codeLink": "See the code", - "revision": "Revision" + "codeLink": "See the code" }, "status": { "connectedToIpfs": "Connected to IPFS", @@ -91,7 +90,8 @@ "totalOut": "Total out", "unknown": "Unknown", "ui": "UI", - "upSpeed": "Outgoing" + "upSpeed": "Outgoing", + "revision": "Revision" }, "tour": { "back": "Back", diff --git a/src/navigation/NavBar.js b/src/navigation/NavBar.js index a34209f8f..050997c8c 100644 --- a/src/navigation/NavBar.js +++ b/src/navigation/NavBar.js @@ -74,7 +74,7 @@ export const NavBar = ({ t }) => {
{ gitRevision &&
- {t('app:nav.revision')} {gitRevision} + {t('app:terms.revision')} {gitRevision}
}
{t('app:nav.codeLink')} diff --git a/src/status/NodeInfo.js b/src/status/NodeInfo.js index 0ea5dcdf4..9eb54df80 100644 --- a/src/status/NodeInfo.js +++ b/src/status/NodeInfo.js @@ -29,7 +29,7 @@ class NodeInfo extends React.Component { } /> - v{process.env.REACT_APP_VERSION}} /> + {process.env.REACT_APP_GIT_REV}} /> ) } From effa23ef461866569b866c80cae3cfcd99db2f8f Mon Sep 17 00:00:00 2001 From: Marcin Rataj Date: Tue, 9 Aug 2022 19:07:14 +0200 Subject: [PATCH 3/3] style: simplify UI revision no need for it to be clicable (kubo version is not) nor for it to say "revision" (it is UI, and not kubo or desktop revision) --- src/status/NodeInfo.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/status/NodeInfo.js b/src/status/NodeInfo.js index 9eb54df80..982d6186b 100644 --- a/src/status/NodeInfo.js +++ b/src/status/NodeInfo.js @@ -29,7 +29,7 @@ class NodeInfo extends React.Component { } /> - {process.env.REACT_APP_GIT_REV}} /> + ) }