Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

createAddStream test fails on Travis CI #572

Closed
daviddias opened this issue Jun 27, 2017 · 11 comments
Closed

createAddStream test fails on Travis CI #572

daviddias opened this issue Jun 27, 2017 · 11 comments

Comments

@daviddias
Copy link
Contributor

Only reproducible on Travis (works locally and on Circle)

@daviddias daviddias added the bug label Jun 27, 2017
@nunofmn
Copy link
Contributor

nunofmn commented Jun 27, 2017

Sometimes I got the test failing locally also.

@victorb
Copy link
Contributor

victorb commented Jun 28, 2017

What I can see it's failing on Travis and Circle ( https://travis-ci.org/ipfs/js-ipfs-api/jobs/247587662 and https://circleci.com/gh/ipfs/js-ipfs-api/1228 ). Most probably a performance issue, so we might want to try to increase the timeout for that test, decrease the amount of data the test uses and/or optimize the function to be faster.

@daviddias
Copy link
Contributor Author

80000ms should be more than enough and the disparity between seeing success and failing suggests that there something that is not happening rather than happening late. It should be a typical streams race condition.

@daviddias daviddias added the ready label Jul 3, 2017
@daviddias
Copy link
Contributor Author

image

Travis is now looking good :)

@daviddias daviddias reopened this Jul 23, 2017
@daviddias
Copy link
Contributor Author

And now it is Circle..

image

@daviddias
Copy link
Contributor Author

fixed with - 3354901

@daviddias
Copy link
Contributor Author

@daviddias daviddias reopened this Sep 2, 2017
@daviddias
Copy link
Contributor Author

Nope, just go-ipfs that got slower and it was timing out the test

@daviddias daviddias reopened this Sep 2, 2017
@daviddias
Copy link
Contributor Author

Sometimes it times out 80s, which is a lot. Definitely needs more investigation

@daviddias daviddias changed the title Investigate why createAddStream test is failing on CI createAddStream test fails on Travis CI Sep 2, 2017
@daviddias
Copy link
Contributor Author

It has been a long day..

@daviddias
Copy link
Contributor Author

@vmx while you are at it, can you check this one as well?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants