-
Notifications
You must be signed in to change notification settings - Fork 299
createAddStream
test fails on Travis CI
#572
Comments
Sometimes I got the test failing locally also. |
What I can see it's failing on Travis and Circle ( https://travis-ci.org/ipfs/js-ipfs-api/jobs/247587662 and https://circleci.com/gh/ipfs/js-ipfs-api/1228 ). Most probably a performance issue, so we might want to try to increase the timeout for that test, decrease the amount of data the test uses and/or optimize the function to be faster. |
80000ms should be more than enough and the disparity between seeing success and failing suggests that there something that is not happening rather than happening late. It should be a typical streams race condition. |
fixed with - 3354901 |
Nope, just go-ipfs that got slower and it was timing out the test |
Sometimes it times out 80s, which is a lot. Definitely needs more investigation |
createAddStream
test is failing on CIcreateAddStream
test fails on Travis CI
It has been a long day.. |
@vmx while you are at it, can you check this one as well? |
Only reproducible on Travis (works locally and on Circle)
The text was updated successfully, but these errors were encountered: