Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

chore: test against latest go-ipfs #590

Merged
merged 5 commits into from
Sep 2, 2017
Merged

chore: test against latest go-ipfs #590

merged 5 commits into from
Sep 2, 2017

Conversation

daviddias
Copy link
Contributor

No description provided.

@daviddias
Copy link
Contributor Author

Seems that new go-ipfs is slower:

https://travis-ci.org/ipfs/js-ipfs-api/jobs/271122984#L5294-L5325

 1) .name "before all" hook:
     Error: Timeout of 20000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  2) .pin "before all" hook:
     Uncaught AssertionError: expected [Error: connect ECONNREFUSED 127.0.0.1:36291] to not exist
      at ipfs.id (test/name.spec.js:42:30)
      at send (src/id.js:9:844)
      at f (node_modules/once/once.js:25:25)
      at ClientRequest.req.on.err (src/utils/request-api.js:9:8573)
      at Socket.socketErrorListener (_http_client.js:401:9)
      at emitErrorNT (internal/streams/destroy.js:64:8)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)
  3) .dht "before all" hook:
     Error: Timeout of 20000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
  
  4) .pubsub promise API "before all" hook:
     Uncaught TypeError: Cannot read property 'currentRetry' of undefined
      at node_modules/async/internal/parallel.js:39:9
      at node_modules/async/internal/once.js:12:16
      at iterateeCallback (node_modules/async/internal/eachOfLimit.js:44:17)
      at node_modules/async/internal/onlyOnce.js:12:16
      at node_modules/async/internal/parallel.js:36:13
      at f (node_modules/once/once.js:25:25)
      at ClientRequest.req.on.err (src/utils/request-api.js:9:8573)
      at Socket.socketErrorListener (_http_client.js:401:9)
      at emitErrorNT (internal/streams/destroy.js:64:8)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

@daviddias
Copy link
Contributor Author

It seems that things got slower and therefore tests started timing out and doing funky things. Bumping the timeouts made them pass.

@daviddias
Copy link
Contributor Author

Ok, other tests solved, now PubSub fails like this:

 1) .pubsub promise API .ls:
      AssertionError: expected [ 'pubsub-tests-0.1301018467081798' ] to deeply equal []
      + expected - actual
      -[
      -  "pubsub-tests-0.1301018467081798"
      -]
      +[]
      
      at ipfs1.pubsub.ls.then (node_modules/interface-ipfs-core/src/pubsub.js:657:34)
      at <anonymous>
      at process._tickCallback (internal/process/next_tick.js:188:7)

@Kubuxu did something change with regards to PubSub in go-ipfs? Maybe @vyzo knows too

@Kubuxu
Copy link

Kubuxu commented Sep 2, 2017

No that I know of.

@daviddias
Copy link
Contributor Author

I believe this was the root cause: ipfs-inactive/interface-js-ipfs-core@1fcca03

Let's see :)

@daviddias
Copy link
Contributor Author

@daviddias
Copy link
Contributor Author

@daviddias
Copy link
Contributor Author

Ok, now it is just a old one that is back:

 .files callback API .add .createAddStream stream of valid files and dirs:
     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

#572

@daviddias daviddias merged commit 40c8f10 into master Sep 2, 2017
@daviddias daviddias deleted the feat/go-ipfs-0.4.10 branch September 2, 2017 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants