This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: Provide access to bundled libraries when in browser #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Apr 4, 2018
Merged
vasco-santos
force-pushed
the
feat_provide-access-to-bundled-libraries-when-in-browser
branch
from
3d4b90a
to
3d468f3
Compare
daviddias
approved these changes
Apr 5, 2018
daviddias
deleted the
feat_provide-access-to-bundled-libraries-when-in-browser
branch
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the bundled libraries mentioned in 406, as well as ipfs/js-ipfs#525 (comment) were added the same way as in
js-ipfs.The
streamwas not added since the current bundlers, such as browserify, rollup and webpack automatically add native implementations for it. Moreover, the same occurs with the Buffer, which is already being exported in the root of the object. For consistency, I added it to types as it is onjs-ipfsand maintained it on the object root, for avoiding a breaking change. However, I think that we should remove the export of theBufferin both places in a future breaking change, in order to decrease the bundle size, as a result of it being automatically added by the bundlers, such asstream.It is also important pointing out that adding this exports increased the bundled size as follows:
Original
PR
For this issue, other 2 PRs were created
Close #406