This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: provide access to multicodec #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niinpatel
force-pushed
the
feat/expose-multicodec
branch
4 times, most recently
from
77a7433
to
6d36db0
Compare
License: MIT Signed-off by: Nitin Patel <[email protected]>
niinpatel
force-pushed
the
feat/expose-multicodec
branch
from
6d36db0
to
52fa1de
Compare
alanshaw
approved these changes
Mar 14, 2019
Here it is: ipfs-inactive/interface-js-ipfs-core#450 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #955
Included
multicodeclibrary in the static exports.Removed
src/types.js. I don't think it is needed anymore because we're exporting the utilities and types statically and not with the ipfs object. (refactor: export types and utilities statically #951 )Also, I think we should also remove the tests for
ipfs.types.in theinterface-ipfs-coreas they are no longer used. Should I also make a PR there for it?License: MIT
Signed-off by: Nitin Patel [email protected]