Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add wrap-with-directory support (HTTP API and Core) #1178

Closed
nunofmn opened this issue Jan 19, 2018 · 9 comments
Closed

Add wrap-with-directory support (HTTP API and Core) #1178

nunofmn opened this issue Jan 19, 2018 · 9 comments
Labels
exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up

Comments

@nunofmn
Copy link
Member

nunofmn commented Jan 19, 2018

Related to ipfs/ipfs-companion#349

Right now, the wrap-with-directory option only works in CLI and support in HTTP API and Core is missing

I already have a working solution that uses the wrap option in js-ipfs-unixfs-engine Importer API.

Question: it is necessary add support to this option in interface-ipfs-core beforehand? (or maybe at least add a tracking issue)

I'm looking forward to open a PR 👍

@daviddias
Copy link
Member

Hey @nunofmn o/ Yeah, add it to interface-ipfs-core. You can submit both PRs at the same time :)

@daviddias daviddias added status/ready Ready to be worked status/in-progress In progress exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up and removed status/ready Ready to be worked labels Jan 25, 2018
@daviddias
Copy link
Member

@nunofmn ping :) Still interested in submitting that PR?

@daviddias daviddias added status/ready Ready to be worked and removed status/in-progress In progress labels Mar 16, 2018
@musicsmithnz
Copy link

musicsmithnz commented Mar 25, 2018

I am quite interested in this feature, as it allows to use the human readable filenames and also to have the filename extension which is useful for [browsers?] recognizing the mime type. What is the current development status of this feature? Is anybody working on this ?

@wraithgar
Copy link
Contributor

I'm attempting to work on this on the js side of things. Just getting started ramping up here so your patience is very much appreciated!

@musicsmithnz
Copy link

musicsmithnz commented Mar 29, 2018

I've been looking at a workaround which uses the recursive option and passes in a directory selected from a HTML5 input directory. I have been having trouble with this and I'm not sure exactly why, it might be something to do with asynchronous loading of the files. I'm interested if anyone else has tried this.

@wraithgar
Copy link
Contributor

Took a stab at this, see the three PRs linked to above.

@daviddias
Copy link
Member

@wraithgar looking good! I'll handle merging and releasing those soon (probably earlier tomorrow) :) Thank you!

@musicsmithnz
Copy link

Thanks guys I'm looking forward to seeing this.

@hacdias
Copy link
Member

hacdias commented May 10, 2018

Closing this since #1329 was merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

5 participants