Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Sharness tests #412

Closed
daviddias opened this issue Aug 11, 2016 · 10 comments
Closed

Sharness tests #412

daviddias opened this issue Aug 11, 2016 · 10 comments

Comments

@daviddias
Copy link
Member

In order to improve the quality and robustness of js-ipfs, it is pretty important to reuse the SHarness testing infrastructure against the js-ipfs http-api.

@chriscool could you help us with that? I think the best first step is to have the go-ipfs cli point at the js-ipfs http-api and test the endpoints that js-ipfs already implements (i.e: object, block, bitswap, add, cat, get). We can do that by pulling go-ipfs as a devdependency and run it in CI

@chriscool
Copy link
Contributor

@diasdavid yeah I started to take a look at that during the Lisbon workshop, but there were a lot of problems, startin with jsipfs version.
I will take another look soon.

@daviddias
Copy link
Member Author

I was more thinking in the lines of using go-ipfs cli to point to js-ipfs http api (ipfs --api='') so that we can tell that both behave the same way, avoiding to have to write the entire CLI.

@dignifiedquire dignifiedquire changed the title SHarness tests Sharness tests Aug 14, 2016
@daviddias
Copy link
Member Author

@chriscool any update about this?

@chriscool
Copy link
Contributor

@diasdavid I had a vacation and I am at the LinuxCon in Toronto now until next Monday.
I will try to take a look at it soon. Or maybe we should plan to discuss it, maybe on IRC, at the end of next week.

@daviddias
Copy link
Member Author

@chriscool how are things? Can we look into this again? jsipfs is now interopable with go-ipfs (so we can have tests that use both at the same time) and the CLI is getting the same features + interface :)

@chriscool
Copy link
Contributor

@diasdavid great that it's now interoperable! Could we discuss it and try to do something tomorrow morning at around 9 am CEST time or are you available now?

@daviddias
Copy link
Member Author

@chriscool I'm currently in NYC, so 9am CEST would be 4am for me. Can we make it in your afternoon?

@chriscool
Copy link
Contributor

@diasdavid then I think 9pm CEST is better for me. That would be 4pm for you.
Is it ok for you?

@chriscool
Copy link
Contributor

@diasdavid actually 9pm CEST is not possible today for me. I forgot that I had planned to meet friends. But it's possible tomorrow (Thursday September 15). Would that work for you?

@daviddias
Copy link
Member Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants