Pick random ports on tests

[hackergrrl]

We ought to gracefully use port zero (like go-ipfs).

  1) http api "before all" hook:
     Uncaught AssertionError: expected [Error: listen EADDRINUSE 127.0.0.1:9090] to not exist
      at tests/test-http-api/index.js:18:27
      at src/http-api/index.js:55:18
      at node_modules/hapi/lib/server.js:269:20
      at done (node_modules/hapi/node_modules/items/lib/index.js:23:21)
      at Server.onError (node_modules/hapi/lib/connection.js:163:16)
      at emitErrorNT (net.js:1253:8)

[daviddias]

go-ipfs doesn't use port 0 for the Gateway, which is where that is failing.

{
  "API": "/ip4/127.0.0.1/tcp/5001",
  "Gateway": "/ip4/127.0.0.1/tcp/8080",
  "Swarm": [
    "/ip4/0.0.0.0/tcp/4001",
    "/ip6/::/tcp/4001"
  ]
}

It is strange however, because I changed the config to launch the http-api on port 9090 to avoid those kind of collisions, but it seems that you had something else running on port 9090?

[hackergrrl]

It does for tests (https://github.com/ipfs/go-ipfs/blob/master/test/sharness/lib/test-lib.sh#L149), and we should too. I run other software on 8080, so I run the gateway on 9090, as may many other users -- 8080 is pretty popular and 9090 is the next most "logical" choice. ;)

[daviddias]

Got it, could you submit a PR for that?

[hackergrrl]

This isn't on my short term list, so let's open it up as Help Wanted until it gets picked up.

[nginnever]

Took a shot at it, was actually playing with this last night.

#94

[daviddias]

thank you :)