Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Awesome Endeavour - Correct libp2p-webrtc-star situation #981

Closed
4 tasks done
daviddias opened this issue Sep 3, 2017 · 1 comment
Closed
4 tasks done

Awesome Endeavour - Correct libp2p-webrtc-star situation #981

daviddias opened this issue Sep 3, 2017 · 1 comment

Comments

@daviddias
Copy link
Member

daviddias commented Sep 3, 2017

Following the ☕️💬 between @diasdavid and @lgierth https://github.com/ipfs/pm/pull/492/files#r136710447

  • libp2p-webrtc-star should encapsulate another multiaddr (as described in the issue) and that means that a /libp2p-webrtc-star/dns4/star-signal.cloud.ipfs.team/wss/ipfs/<your-peer-id> should in fact be /dns4/star-signal.cloud.ipfs.team/wss/libp2p-webrtc-star/ipfs/<your-peer-id>. This requires
    • Updating js-mafmt
    • Bubble up all the changes through the dep tree
  • Change libp2p-webrtc-star to p2p-webrtc-star (so that it matches the nomenclature also used by p2p-circuit)
@daviddias daviddias changed the title Awesome Endeavour - Correct libp2p-webrtc-star addrs Awesome Endeavour - Correct libp2p-webrtc-star situation Sep 3, 2017
daviddias referenced this issue in ipfs/js-ipfs-bitswap Sep 3, 2017
@daviddias
Copy link
Member Author

And with #984, this endeavor ends!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant