Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: getConfig should return the whole config #152

Closed
thisconnect opened this issue Jun 21, 2017 · 4 comments
Closed

BUG: getConfig should return the whole config #152

thisconnect opened this issue Jun 21, 2017 · 4 comments

Comments

@thisconnect
Copy link
Contributor

If no key is passed, the whole config is returned as an object.

https://ipfs.github.io/js-ipfsd-ctl/#nodegetconfig

currently it returns Error: Failed to get config value: " key has no attributes"

see #151
@thisconnect
Copy link
Contributor Author

Another test fails on Node 6 https://travis-ci.org/ipfs/js-ipfsd-ctl/builds/244451297

@thisconnect thisconnect mentioned this issue Jun 21, 2017
Merged
@thisconnect
Copy link
Contributor Author

After reopening the PR, the other test now fails on Node 4 https://travis-ci.org/ipfs/js-ipfsd-ctl/builds/245233174

@daviddias
Copy link
Member

Thank you for fixing the config bit. Let's review the remaining bugs in another issue/PR

@thisconnect
Copy link
Contributor Author

thisconnect commented Jun 24, 2017 •
edited
Loading

Sure, not sure what it could be but I opened a new issue for the random CI failures #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thisconnect @daviddias