Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remaining tests on Windows once ipfs-api is fixed #167

Closed
richardschneider opened this issue Nov 10, 2017 · 8 comments
Closed

Enable remaining tests on Windows once ipfs-api is fixed #167

richardschneider opened this issue Nov 10, 2017 · 8 comments
Assignees

Comments

@richardschneider
Copy link
Contributor

This package and tests should run on Windows

@richardschneider
Copy link
Contributor Author

Many of the tests use unix tools (tail, ps, ...). The windows equivalent will be need.

@daviddias
Copy link
Member

The tests are running on Windows https://ci.appveyor.com/project/diasdavid/js-ipfsd-ctl-a9ywu for a while. What's missing?

@thisconnect
Copy link
Contributor

@richardschneider there are 2 parts excluded by checking isWindows
https://github.com/ipfs/js-ipfsd-ctl/blob/master/test/spawning-daemons.spec.js

forgot what it was all about

@daviddias daviddias changed the title Windows interop Testing remaining tests in windows Nov 10, 2017
@daviddias
Copy link
Member

Those are actually issues from https://github.com/ipfs/js-ipfs-api and not ipfsd-ctl itself

@daviddias daviddias changed the title Testing remaining tests in windows Enable remaining tests on Windows once ipfs-api is fixed Nov 10, 2017
@richardschneider
Copy link
Contributor Author

@diasdavid It is NOT running on windows see ipfs-inactive/js-ipfs-http-client#623

This was referenced Nov 16, 2017
@richardschneider
Copy link
Contributor Author

There's a check() that is skipped for windows. It checks that the "repo" is correct after stopping a daemon.

According to nodejs process.kill() and signals are just broken. More investigation of subcomandante is required.

@daviddias
Copy link
Member

Once again, excellent work with #174 👏🏽👏🏽👏🏽👏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants