feat: use default daemon addrs #220
Conversation
ghost
assigned 
|
@dryajov is this working already? 😄 |
|
Yup. Can you do a CR 😉? |
|
Hoping CR means something like "Closing Review", I did it 😆 |
|
Oh |
|
Thanks eheh. When you merge this and release a new version, could you ping me please? |
|
@JonKrone it's addressing this issue - ipfs/ipfs-desktop#617 |
|
@dryajov CI is not yet green. Can you get that done before more reviews? |
dryajov
force-pushed
the
feat/default-addrs
branch
from
1156a88
to
012cba3
Compare
|
CI is mostly failing because this adds the ability to use the daemon's default ports, which conflicts on jenkins since tests are not isolated. We'll probably have to skip this tests on jenkins for now.
|
|
Skiping the default addrs test fixes jenkins. But circle ci is really broken for some reason, there are a bunch of timeouts everywhere. I'm not sure if its related to the recent outage or if its something else. |
|
@diasdavid circleci is having some serious issues, but I don't think it's related to these changes. After I disabled the default addrs tests, jenkins and travis are now both green, however circle keeps failing on random timeouts. I'm not sure what's the best way of verifying that circle is the one with the issues besides closing this PR and opening a new one? @victorbjelkholm whats the versions of node that circle is on, I can't seem to find it anywhere in the logs, that could be the reason it's failing since #223 as been brought up. |
Eeeh, hm. You can see under the |
|
@victorbjelkholm ah thanks! So it is v9.9.0... thats why its soooo very sick. |
test/spawn-options.spec.js
Outdated
| @@ -186,6 +188,50 @@ describe('Spawn options', function () { | |||
| }) | |||
| }) | |||
|
|
|||
| // TODO re-enable when jenkins runs tests in isolation | |||
| dscskip('spawn with default swarm addrs', () => { | |||
There was a problem hiding this comment.
just replace for describe.skip, it is just being used once
|
@victorbjelkholm do we have a way of determining if we're running in jenkins (env variable)? |
No description provided.