Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speed boost: gen 200 PeerIds in advance #280

Closed
daviddias opened this issue Jul 15, 2018 · 1 comment · Fixed by #284
Closed

speed boost: gen 200 PeerIds in advance #280

daviddias opened this issue Jul 15, 2018 · 1 comment · Fixed by #284
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP

Comments

@daviddias
Copy link
Member

Me, @hugomrdias and @vasco-santos talked about this last week. If we have 200 PeerIds generated before hand, we can add a option to ipfsd-ctl that tells it just being used for tests (e.g. { test: true }) so that it takes from the PeerId pool rather than trying to gen PeerIds each time. This will dramatically speed up tests everywhere.
@daviddias daviddias added the status/ready Ready to be worked label Jul 16, 2018
@hugomrdias hugomrdias added exp/wizard Extensive knowledge (implications, ramifications) required P0 Critical: Tackled by core team ASAP kind/enhancement A net-new feature or improvement to an existing feature labels Aug 27, 2018
@hugomrdias
Copy link
Member

check PR #284

@mkg20001 mkg20001 mentioned this issue Aug 28, 2018
Merged
@ghost ghost removed the status/ready Ready to be worked label Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Use pregenerated ids for testing mkg20001/js-ipfsd-ctl
2 participants
@hugomrdias @daviddias