chore: remove pubsub flags #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: pubsub flags for in-proc daemons will not set values anymore
1 task
vasco-santos
commented
Sep 4, 2019
| @@ -87,7 +87,7 @@ | |||
| "dirty-chai": "^2.0.1", | |||
| "go-ipfs-dep": "~0.4.22", | |||
| "husky": "^3.0.4", | |||
| "ipfs": "ipfs/js-ipfs#master", | |||
| "ipfs": "~0.37.1", | |||
There was a problem hiding this comment.
We can go back to the older version with this, as we don't need js-ipfs to support --enable-pubsub anymore
hugomrdias
approved these changes
Sep 5, 2019
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Sep 5, 2019
As discussed, we will remove the pubsub flags from the js daemon and will use the config as the way to disable it (will be enabled by default now!) Needs: - [x] [ipfs/js-ipfsd-ctl#366](ipfs/js-ipfsd-ctl#366) Reference: - [ipfs/kubo#6621](ipfs/kubo#6621) BREAKING CHANGE: pubsub is now enabled by default and the experimental flag was removed
This was referenced Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: pubsub flags for in-proc daemons will not set values anymore
As discussed, we will remove the pubsub flags from the js daemon and will use the config as the way to disable it (will be enabled by default now!)
Ref: