fix: fix non-disposable and normalises behaviour #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomrdias
force-pushed
the
fix/normalize-options
branch
from
f95d011
to
5c1a6ce
Compare
achingbrain
reviewed
Sep 18, 2019
package.json
Outdated
| "execa": "^2.0.4", | ||
| "fs-extra": "^8.1.0", | ||
| "hat": "~0.0.3", | ||
| "ipfs-http-client": "^36.0.0", | ||
| "ipfs-http-client": "^36.1.0", |
There was a problem hiding this comment.
v37 is out - breaking change is minor, just downgrades multiaddr from v7 to v6 until we can upgrade all js-ipfs* in one go.
achingbrain
reviewed
Sep 18, 2019
achingbrain
reviewed
Sep 18, 2019
| const daemonOptions = merge({ | ||
| exec: this.options.exec, | ||
| type: this.options.type, | ||
| IpfsClient: this.options.IpfsClient, |
There was a problem hiding this comment.
I wish this was just client
There was a problem hiding this comment.
Not actionable feedback, please ignore.
achingbrain
approved these changes
Sep 18, 2019
This was referenced Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks daemon spawn options and handling of start/init, it also makes sure spawned daemons attach themselves to running daemons on the default/provided repo.
Some dependencies were also removed.
Ref: #304
closes #305
closes #276
closes #354
closes #330
closes #329