Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert multiaddr #393

Merged
merged 1 commit into from
Oct 10, 2019
Merged

fix: revert multiaddr #393

merged 1 commit into from
Oct 10, 2019

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Oct 10, 2019

This PR reverts multiaddr to v6 to avoid problems about mixing v6 and v7.
Will change back when all repos update to v7.

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add descriptions of what a given PR is supposed to fix? I mean, I think I know in this case but it would be good to understand the intention behind a change as well as the implementation.

@hugomrdias
Copy link
Member Author

Can you please add descriptions of what a given PR is supposed to fix? I mean, I think I know in this case but it would be good to understand the intention behind a change as well as the implementation.

done sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants