feat: force kill daemons after timeout #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2020 12:29
This PR re-adds a feature that was removed in 1.0.0 whereby daemons are force killed with a SIGKILL when they do not stop within a timeout. It adds 2 new options to the `Daemon` class - `forceKill` (boolean - default `true`) and `forceKillTimeout` (number - default 10000).
3 tasks
achingbrain
approved these changes
Jan 22, 2020
|
The new options need documenting here: https://github.com/ipfs/js-ipfsd-ctl#stop |
hugomrdias
suggested changes
Jan 23, 2020
|
Answering the question in ipfs/interop#96 (comment), just send a SIGKILL. There's no real need to wait the 10s. If someone wants to try to debug this:
|
|
@Stebalien thanks, so maybe we should reduce the timeout, wait 5s for |
|
SGTM! |
|
@hugomrdias I've pushed changes to this branch that address the PR comments (I think) - can it go in? |
hugomrdias
suggested changes
Jan 29, 2020
hugomrdias
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-adds a feature that was removed in 1.0.0 whereby daemons are force killed with a SIGKILL when they do not stop within a timeout.
It adds 2 new options to the
Daemonclass -forceKill(boolean - defaulttrue) andforceKillTimeout(number - default 10000).resolves #438