Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept symbolic links as mounting scripts in the Docker image #10519

Open
3 tasks done
jesusvico opened this issue Sep 17, 2024 · 0 comments
Open
3 tasks done

Accept symbolic links as mounting scripts in the Docker image #10519

jesusvico opened this issue Sep 17, 2024 · 0 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization

Comments

@jesusvico
Copy link

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

Now, only regular files are accepted as valid mounting scripts in the Docker image.

# /kubo/bin/container_daemon

#...

find /container-init.d -maxdepth 1 -type f -iname '*.sh' -print0 | sort -z | xargs -n 1 -0 -r container_init_run

This could be fixed with the following change:

find /container-init.d -maxdepth 1 \( -type f -o -type l \) -iname '*.sh' -print0

When using Kubernetes, ConfigMaps are mounted as symbolic links. Because of this, I cannot easily use the mounting script functionality.

@jesusvico jesusvico added the kind/enhancement A net-new feature or improvement to an existing feature label Sep 17, 2024
@lidel lidel added the need/triage Needs initial labeling and prioritization label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants