Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http serve doesnt work #163

Closed
whyrusleeping opened this issue Oct 13, 2014 · 2 comments · Fixed by #167
Closed

Http serve doesnt work #163

whyrusleeping opened this issue Oct 13, 2014 · 2 comments · Fixed by #167
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@whyrusleeping
Copy link
Member

ipfs serve http hangs in setupCmdContext(...) where it tries to find the root command object (the for loop). It appears something is weird with the treelike structure of the commands...

cc @jbenet
@whyrusleeping whyrusleeping added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue labels Oct 13, 2014
@cryptix
Copy link
Contributor

cryptix commented Oct 14, 2014

yep, the problem was with the for loop. It just worked for one level deep commands since it used c.Parent from the calling argument, c.Parent was still the same on the next iteration.

@cryptix cryptix mentioned this issue Oct 14, 2014
Merged
@jbenet
Copy link
Member

jbenet commented Oct 14, 2014

Ah derp, my mistake!

@aschmahmann aschmahmann mentioned this issue Feb 18, 2021
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix setupCmdContext() for subcommands
3 participants
@cryptix @jbenet @whyrusleeping