Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config validations #2491

Open
whyrusleeping opened this issue Mar 21, 2016 · 2 comments
Open

add config validations #2491

whyrusleeping opened this issue Mar 21, 2016 · 2 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue

Comments

@whyrusleeping
Copy link
Member

We should set up hooks for certain config keys to validate that can be run when the user modifies them.

The validations should also be run during init to make sure that any modifications the user makes directly to the file get validated as well
@dignifiedquire
Copy link
Member

This issue was brought to you by @dignifiedquire's hammer comments

@ghost
Copy link

ghost commented Mar 21, 2016

I guess something similar to e.g. nginx's configtest? Other server software has similar functionality, I know apache and mysql do.

@whyrusleeping whyrusleeping added the exp/expert Having worked on the specific codebase is important label Apr 1, 2016
@whyrusleeping whyrusleeping mentioned this issue Apr 18, 2016
Closed
@RichardLitt RichardLitt added help wanted Seeking public contribution on this issue and removed help wanted Seeking public contribution on this issue labels May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dignifiedquire @RichardLitt @whyrusleeping