Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set --manage-fdlimit to true, and have the default value for fds be 1024 #2845

Closed
whyrusleeping opened this issue Jun 13, 2016 · 1 comment
Closed
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@whyrusleeping
Copy link
Member

The current default of behaviour of ipfs is to not touch the fd limit (even if it is unsufficient). The reasoning for this is that we want to respect user defined limits on the program. I think though, that it is reasonable to raise the limit in the case that it is lower than 1024. Ipfs does not run well when it is given fewer than 1024 file descriptors to work with.

To this end, the option to ipfs daemon, --manage-fdlimit should now default to true, and we should set the file descriptor to 1024 in the default case (while still respecting the environment variable for that if set).

@whyrusleeping whyrusleeping added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up labels Jun 13, 2016
@Kubuxu
Copy link
Member

Kubuxu commented Jun 23, 2016

Resolved in: #2884

@Kubuxu Kubuxu closed this as completed Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants