Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: multiple GOPATH components #2947

Closed
djdv opened this issue Jul 6, 2016 · 1 comment
Closed

Build: multiple GOPATH components #2947

djdv opened this issue Jul 6, 2016 · 1 comment

Comments

@djdv
Copy link
Contributor

djdv commented Jul 6, 2016

Version/Platform/Processor information (from ipfs version --all):
N/A
Type (bug, feature, meta, test failure, question):
Bug
Area (api, commands, daemon, fuse, etc):
Build system
Priority (from P0: functioning, to P4: operations on fire):
P1

Description:
A patch was merged #2808 that resolved this issue but was reverted #2862 there was no original issue ticket filed, I am filling this one so that the revert issue (#2833) may be closed without dropping awareness of the issue.

Original text by @karalabe from #2808 below:

Go's GOPATH environment variable can contain multiple paths, separated by a colon : similar to the PATH env var. In such cases Go uses the first path element to install any packages, however the remaining paths are still used to find dependencies. Because of this it's quite a common setup to have multiple paths listed in GOPATH (e.g. one for development and another for appengine, which has its special installer).

The current Makefile however erroneously assumes that GOPATH contains a single path element, and tries to locate go-ipfs within by appending a string to GOPATH, which is obviously cause an invalid path, and hence fail the path_check rule in the Makefile, even though the required condition is met.

@Kubuxu
Copy link
Member

Kubuxu commented Jul 6, 2016

I think the problem is that in Windows the path separator would be ;.

So we would need if we run Windows && !Cygwin then change the path separator to ;.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants