Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs swarm peers -v may output a 0 latency #3125

Closed
jbenet opened this issue Aug 26, 2016 · 0 comments · Fixed by #3491
Closed

ipfs swarm peers -v may output a 0 latency #3125

jbenet opened this issue Aug 26, 2016 · 0 comments · Fixed by #3491
Assignees
@whyrusleeping
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@jbenet
Copy link
Member

jbenet commented Aug 26, 2016 •
edited by whyrusleeping
Loading

Version/Platform/Processor information (from ipfs version --all):

go-ipfs version: 0.4.3-rc3-
Repo version: 4
System version: amd64/darwin
Golang version: go1.6.2

Type (bug, feature, meta, test failure, question):

bug?

Area (api, commands, daemon, fuse, etc):

commands

Priority (from P0: functioning, to P4: operations on fire):

P1

Description:

It seems that ipfs swarm peers -v prints 0 for peers whose latencies are unknown. I'm not sure this is the best output decision. I think this happens because not enough latency info has been collected, but im not sure.

I dont know what other possible value we would show-- maybe n/a or need more data or don't print anything? I wouldn't want some tool to do stupid things because "ZOMG 0 latency!"

> ipfs swarm peers -v
/ip4/104.236.151.122/tcp/4001/ipfs/QmSoLju6m7xTh3DuokvT3886QRYqxAzb1kShaanJgW36yx 89.148971ms
/ip4/104.236.176.52/tcp/4001/ipfs/QmSoLnSGccFuZQJzRadHn95W2CrSFmZuTdDWP8HXaHca9z 97.973656ms
/ip4/104.236.176.59/tcp/4001/ipfs/QmQ8MYL1ANybPTM5uamhzTnPwDwCFgfrdpYo9cwiEmVsge 0
/ip4/159.203.17.173/tcp/4001/ipfs/QmWmJvCpjMuBZX4MYWupb9GB3qNYVa1igYCsAQfSHmFJde 0
/ip4/170.75.162.237/tcp/4001/ipfs/QmbeSe5BtzdMomPhQKa1EaSyKiNxtAPXj8LDf6VGhocZTw 0
/ip4/178.62.158.247/tcp/4001/ipfs/QmSoLer265NRgSp2LA3dPaeykiS1J6DifTC88f5uVQKNAd 190.014865ms
/ip4/178.62.61.185/tcp/4001/ipfs/QmSoLMeWqB7YGVLJN3pNLQpmmEk35v6wYtsMGLzSr5QBU3 83.255268ms
/ip4/192.241.197.120/tcp/4001/ipfs/QmSGYB8socm1hcrFg4gibMYWNcjTh37xRLRVtgoU9vmg3w 0
/ip4/195.190.112.134/tcp/4001/ipfs/QmZCi3E7cpt65z3qyK5pR1pAbg51rMdRAY61ktPSVDMfme 0
/ip4/198.143.1.139/tcp/4001/ipfs/QmXfZmZRLeeMib55XXZZuNRMS6VpQMo8nEnSdMQ3yQstVh 0
/ip4/212.47.243.156/tcp/4001/ipfs/QmPCfdoA8aDscrfNVAhB12YYJJ2CR9mDG2WtKYFoxwL182 127.943761ms
/ip4/37.144.90.132/tcp/32513/ipfs/QmQs6Poz3c8h3PG3UujQi1z4zfDJY6pa3YonUvkE3RvgYu 0
/ip4/50.148.146.226/tcp/55918/ipfs/QmVSLvQjRYgAvCvSoztzJSh4kDfGhLgju87U8qTZFJyrt6 0
/ip4/52.166.250.182/tcp/4001/ipfs/QmX5atbJejoCr2UERFPPhifCkfkd9BQL64NZGMUcDYHYvr 0
/ip4/52.86.54.39/tcp/4001/ipfs/QmYUigsBb9bhu9BcVXXaQAJRhhLHvDQ4yJ9trxTbr7CsEj 18.343808ms
/ip4/54.197.165.255/tcp/4001/ipfs/QmdsoQ8xhfkaEpAYCLJ75LEiup9E4ybUdbqDkZZKggfWjS 0
/ip4/71.89.18.70/tcp/40017/ipfs/QmYdB77JtUKJG1TMtwSNNfFwjG49XxE1Hj1aEsYSkp14TN 0
/ip4/83.246.72.225/tcp/4001/ipfs/QmdXxPfivthooUFh9grEXb4mSFfLWNVAEeJ57HhDnoz8fk 0
/ip4/91.126.205.225/tcp/38683/ipfs/QmNs4oLQZPnDK73ZYnAYYhwvfYifsncTF1T7L3S613Tf64 0
/ip6/fc98:424c:b433:d7e2:7ee3:9541:73ff:2cdb/tcp/54292/ipfs/QmSoLPppuBtQSGwKDZT2M73ULpjvfd3aZ6ha4oFGL1KrGM 0
> ipfs ping QmQ8MYL1ANybPTM5uamhzTnPwDwCFgfrdpYo9cwiEmVsge
PING QmQ8MYL1ANybPTM5uamhzTnPwDwCFgfrdpYo9cwiEmVsge.
Pong received: time=154.45 ms
Pong received: time=77.66 ms
Pong received: time=79.34 ms
Pong received: time=79.25 ms
Pong received: time=79.11 ms
^C
02:34:30.650 ERROR commands/h: net/http: request canceled client.go:247
> ipfs swarm peers -v
/ip4/104.236.151.122/tcp/4001/ipfs/QmSoLju6m7xTh3DuokvT3886QRYqxAzb1kShaanJgW36yx 89.148971ms
/ip4/104.236.176.52/tcp/4001/ipfs/QmSoLnSGccFuZQJzRadHn95W2CrSFmZuTdDWP8HXaHca9z 97.973656ms
/ip4/104.236.176.59/tcp/4001/ipfs/QmQ8MYL1ANybPTM5uamhzTnPwDwCFgfrdpYo9cwiEmVsge 123.359133ms
/ip4/159.203.17.173/tcp/4001/ipfs/QmWmJvCpjMuBZX4MYWupb9GB3qNYVa1igYCsAQfSHmFJde 0
/ip4/170.75.162.237/tcp/4001/ipfs/QmbeSe5BtzdMomPhQKa1EaSyKiNxtAPXj8LDf6VGhocZTw 0
/ip4/178.62.158.247/tcp/4001/ipfs/QmSoLer265NRgSp2LA3dPaeykiS1J6DifTC88f5uVQKNAd 190.014865ms
/ip4/178.62.61.185/tcp/4001/ipfs/QmSoLMeWqB7YGVLJN3pNLQpmmEk35v6wYtsMGLzSr5QBU3 83.255268ms
/ip4/192.241.197.120/tcp/4001/ipfs/QmSGYB8socm1hcrFg4gibMYWNcjTh37xRLRVtgoU9vmg3w 0
/ip4/195.190.112.134/tcp/4001/ipfs/QmZCi3E7cpt65z3qyK5pR1pAbg51rMdRAY61ktPSVDMfme 0
/ip4/198.143.1.139/tcp/4001/ipfs/QmXfZmZRLeeMib55XXZZuNRMS6VpQMo8nEnSdMQ3yQstVh 0
/ip4/212.47.243.156/tcp/4001/ipfs/QmPCfdoA8aDscrfNVAhB12YYJJ2CR9mDG2WtKYFoxwL182 127.943761ms
/ip4/37.144.90.132/tcp/32513/ipfs/QmQs6Poz3c8h3PG3UujQi1z4zfDJY6pa3YonUvkE3RvgYu 0
/ip4/50.148.146.226/tcp/55918/ipfs/QmVSLvQjRYgAvCvSoztzJSh4kDfGhLgju87U8qTZFJyrt6 0
/ip4/52.166.250.182/tcp/4001/ipfs/QmX5atbJejoCr2UERFPPhifCkfkd9BQL64NZGMUcDYHYvr 0
/ip4/52.86.54.39/tcp/4001/ipfs/QmYUigsBb9bhu9BcVXXaQAJRhhLHvDQ4yJ9trxTbr7CsEj 18.343808ms
/ip4/54.197.165.255/tcp/4001/ipfs/QmdsoQ8xhfkaEpAYCLJ75LEiup9E4ybUdbqDkZZKggfWjS 0
/ip4/71.89.18.70/tcp/40017/ipfs/QmYdB77JtUKJG1TMtwSNNfFwjG49XxE1Hj1aEsYSkp14TN 0
/ip4/83.246.72.225/tcp/4001/ipfs/QmdXxPfivthooUFh9grEXb4mSFfLWNVAEeJ57HhDnoz8fk 0
/ip4/91.126.205.225/tcp/38683/ipfs/QmNs4oLQZPnDK73ZYnAYYhwvfYifsncTF1T7L3S613Tf64 0
/ip6/fc98:424c:b433:d7e2:7ee3:9541:73ff:2cdb/tcp/54292/ipfs/QmSoLPppuBtQSGwKDZT2M73ULpjvfd3aZ6ha4oFGL1KrGM 0
> ipfs version --all
go-ipfs version: 0.4.3-rc3-
Repo version: 4
System version: amd64/darwin
Golang version: go1.6.2
> ipfs swarm peers -v
/ip4/104.236.151.122/tcp/4001/ipfs/QmSoLju6m7xTh3DuokvT3886QRYqxAzb1kShaanJgW36yx 95.169573ms
/ip4/104.236.176.52/tcp/4001/ipfs/QmSoLnSGccFuZQJzRadHn95W2CrSFmZuTdDWP8HXaHca9z 93.39557ms
/ip4/104.236.176.59/tcp/4001/ipfs/QmQ8MYL1ANybPTM5uamhzTnPwDwCFgfrdpYo9cwiEmVsge 135.085897ms
/ip4/159.203.17.173/tcp/4001/ipfs/QmWmJvCpjMuBZX4MYWupb9GB3qNYVa1igYCsAQfSHmFJde 63.195204ms
/ip4/170.75.162.237/tcp/4001/ipfs/QmbeSe5BtzdMomPhQKa1EaSyKiNxtAPXj8LDf6VGhocZTw 97.382402ms
/ip4/178.62.158.247/tcp/4001/ipfs/QmSoLer265NRgSp2LA3dPaeykiS1J6DifTC88f5uVQKNAd 195.990591ms
/ip4/178.62.61.185/tcp/4001/ipfs/QmSoLMeWqB7YGVLJN3pNLQpmmEk35v6wYtsMGLzSr5QBU3 86.481327ms
/ip4/192.241.197.120/tcp/4001/ipfs/QmSGYB8socm1hcrFg4gibMYWNcjTh37xRLRVtgoU9vmg3w 171.703139ms
/ip4/195.190.112.134/tcp/4001/ipfs/QmZCi3E7cpt65z3qyK5pR1pAbg51rMdRAY61ktPSVDMfme 263.011944ms
/ip4/198.143.1.139/tcp/4001/ipfs/QmXfZmZRLeeMib55XXZZuNRMS6VpQMo8nEnSdMQ3yQstVh 22.063147ms
/ip4/212.47.243.156/tcp/4001/ipfs/QmPCfdoA8aDscrfNVAhB12YYJJ2CR9mDG2WtKYFoxwL182 128.04589ms
/ip4/37.144.90.132/tcp/32513/ipfs/QmQs6Poz3c8h3PG3UujQi1z4zfDJY6pa3YonUvkE3RvgYu 252.286619ms
/ip4/50.148.146.226/tcp/55918/ipfs/QmVSLvQjRYgAvCvSoztzJSh4kDfGhLgju87U8qTZFJyrt6 173.975122ms
/ip4/52.166.250.182/tcp/4001/ipfs/QmX5atbJejoCr2UERFPPhifCkfkd9BQL64NZGMUcDYHYvr 97.839919ms
/ip4/52.86.54.39/tcp/4001/ipfs/QmYUigsBb9bhu9BcVXXaQAJRhhLHvDQ4yJ9trxTbr7CsEj 64.086011ms
/ip4/54.197.165.255/tcp/4001/ipfs/QmdsoQ8xhfkaEpAYCLJ75LEiup9E4ybUdbqDkZZKggfWjS 31.429544ms
/ip4/71.89.18.70/tcp/40017/ipfs/QmYdB77JtUKJG1TMtwSNNfFwjG49XxE1Hj1aEsYSkp14TN 238.235634ms
/ip4/83.246.72.225/tcp/4001/ipfs/QmdXxPfivthooUFh9grEXb4mSFfLWNVAEeJ57HhDnoz8fk 184.623015ms
/ip4/91.126.205.225/tcp/38683/ipfs/QmNs4oLQZPnDK73ZYnAYYhwvfYifsncTF1T7L3S613Tf64 744.638991ms
/ip6/fc3a:6516:6c0e:37fd:c9be:af6c:7e23:7ea8/tcp/46812/ipfs/QmURgqkTQXV3ps9WZwkvnARiG9qQUHxc5Mr4xMQHMrUUGP 712.377676ms
/ip6/fc98:424c:b433:d7e2:7ee3:9541:73ff:2cdb/tcp/54292/ipfs/QmSoLPppuBtQSGwKDZT2M73ULpjvfd3aZ6ha4oFGL1KrGM 200.760776ms
@jbenet jbenet mentioned this issue Aug 28, 2016
Closed
58 tasks
@em-ly em-ly added the kind/bug A bug in existing code (including security flaws) label Aug 29, 2016
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 14, 2016
@whyrusleeping whyrusleeping added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
@whyrusleeping whyrusleeping mentioned this issue Dec 9, 2016
Merged
@whyrusleeping whyrusleeping self-assigned this Dec 9, 2016
@whyrusleeping whyrusleeping added status/in-progress In progress and removed status/deferred Conscious decision to pause or backlog labels Dec 9, 2016
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whyrusleeping whyrusleeping

Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swarm/peers: print 'n/a' instead of zero latency ipfs/kubo
3 participants
@jbenet @whyrusleeping @em-ly