-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extracting importers requires extracting many things, let me know if I can go ahead #4679
Comments
@hsanjuan All of this sounds good except pin. I don't think that one is necessary quite yet, is it? In any case, i'm 👍 for having these extracted. |
how about: start working on this, do exchange+bitswap last. We're working on a fix to bitswap that will hopefully be the last piece before the 0.4.14 release. Once that release is in, we can merge all these extractions. |
There is a dep from blocks/blockstore to pin (removing a block needs a pinner to unpin, if I remember well). I can't do exchange last because it's not the top dependency, but I can wait and do others in the meantime. |
@whyrusleeping what if I extract just the |
Extracting exchange+bitswap now will make #4333 a bit annoying to fix (not that it doesn't have enough conflicts now), AFAIK we wanted to merge 4333 after 0.4.14 is released. so that shouldn't block this for long |
@magik6k ack. not touching exchange for the moment. |
Also what the motivation for separating these out? |
This has happened (the package lives in https://github.com/ipfs/go-unixfs) |
If I got it right, extracting the
importer
module for re-use in ipfs-cluster to use it is going to require to additionally extract (because of intermodule deps):This is a bit of work and I want to make sure we you are OK with it? Or would you rather do things (or have me do things) differently?
@whyrusleeping @Stebalien
The text was updated successfully, but these errors were encountered: