Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cat offset and large files #5380

Closed
richardschneider opened this issue Aug 14, 2018 · 3 comments
Closed

cat offset and large files #5380

richardschneider opened this issue Aug 14, 2018 · 3 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature topic/commands Topic commands

Comments

@richardschneider
Copy link

The cat command/API now accepts an offset and length.

Files bigger than 2^32 bytes can not be read because the offset is only an int not a long

offset and possibly length should accept long values.

@Stebalien
Copy link
Member

This will, unfortunately, require changes to the commands lib. However, you're absolutely right.

@Stebalien Stebalien added kind/enhancement A net-new feature or improvement to an existing feature topic/commands Topic commands status/deferred Conscious decision to pause or backlog labels Aug 15, 2018
@overbool
Copy link
Contributor

Hey @Stebalien, I think modifying IntOption/UintOption to Int64Option/Uint64Option maybe can solve this issue?

@Stebalien
Copy link
Member

We'd probably want to add a type instead of replacing the existing one.

@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature topic/commands Topic commands
Projects
None yet
Development

No branches or pull requests

3 participants