Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding swarm filters to default profile #6925

Closed
RubenKelevra opened this issue Feb 24, 2020 · 4 comments
Closed

adding swarm filters to default profile #6925

RubenKelevra opened this issue Feb 24, 2020 · 4 comments
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@RubenKelevra
Copy link
Contributor

Currently, the server profile got a swarm filter for private subnetworks (IPv4/6).

A not so strict swarm filter should be part of the standard profile as well, allowing for connections based on mDNS-discoveries.

Usual home users just use mDNS, so connecting to announced private IPs doesn't make much sense for them and just waste CPU time/system resources and maybe even conntracking space in the home-router.

@RubenKelevra RubenKelevra added the kind/enhancement A net-new feature or improvement to an existing feature label Feb 24, 2020
@Stebalien
Copy link
Member

Duplicate?

@RubenKelevra
Copy link
Contributor Author

Duplicate?

Nope, #6926 was about what it's going to be announced to the network.

This one is about what a default client is going to connect to.

I think we should just add all the swarm filters which are already part of the server profile.

Just make sure that nodes detected via mDNS are still allowed to be connected.


If someone is currently announcing like 10.10.2.2 my client would try to connect to this IP address which has no usecase.

If someone really wants to connect clients in different private IP ranges he/she would probably use the bootstrap function and don't rely on announces to thru the internet.

@RubenKelevra
Copy link
Contributor Author

@Stebalien please reopen :)

@Stebalien
Copy link
Member

Got it. This is part of libp2p/go-libp2p#436 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants