-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InterruptReply missing status and error properties #1100
Comments
Good catch! Would you like to submit a PR? |
It would be good to add a check in the tests at ipykernel/ipykernel/tests/test_kernel_direct.py Lines 71 to 73 in ea33a31
ipykernel/ipykernel/tests/test_ipkernel_direct.py Lines 92 to 94 in ea33a31
(and to change those tests to send the interrupt request on the control channel instead of the shell channel). |
i can get a PR in next week @blink1073. |
Great, thanks! |
any idea where i can get the traceback? |
I would set a debug point in the tests and inspect the |
According to the jupyter messaging docs, we should be passing a
status
field in the content of theInterruptReply
message. However in the implementation, we are just forwarding the request content (empty) back into the reply. As such, the reply has no information onstatus
and the error properties in case the interrupt is not successful.My suggestion on the fix should be a try catch around the
send_interrupt_children
and return a{ 'status' : 'ok' }
if no catch occurs and otherwise{ 'status': 'error', ... }
.The text was updated successfully, but these errors were encountered: