Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Enum for msg_types #833

Open
echarles opened this issue Jan 7, 2022 · 0 comments
Open

Use Enum for msg_types #833

echarles opened this issue Jan 7, 2022 · 0 comments

Comments

@echarles
Copy link
Member

echarles commented Jan 7, 2022

The msg_types would deserve some Enum

msg_types = [
'execute_request', 'complete_request',
'inspect_request', 'history_request',
'comm_info_request', 'kernel_info_request',
'connect_request', 'shutdown_request',
'is_complete_request', 'interrupt_request',
# deprecated:
'apply_request',
]
# add deprecated ipyparallel control messages
control_msg_types = msg_types + ['clear_request', 'abort_request', 'debug_request']

This has been spotted by @Carreau while reviewing #805 in this comment #805 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant