Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what it means for clients to support batch #177

Open
DanielOaks opened this issue Nov 9, 2017 · 4 comments
Open

Clarify what it means for clients to support batch #177

DanielOaks opened this issue Nov 9, 2017 · 4 comments

Comments

@DanielOaks
Copy link
Member

It's pretty explicit when servers support batches. Q: Do they send batches. A: Y/N.

However, when it comes to clients... it's much less explicit. Some example questions we could apply:

  • Do they request the batch capability by default?
  • Internally, can they track which messages are part of which batches?
  • Can they post-process messages after they receive the 'batch end' message, collapsing them to display more nicely?
  • Do they correctly collapse one or more of the standard batch types, and handle them explicitly?

I dunno, it's hard to say when a client really supports 'batches'. What I think makes the most sense is for the actual batch column on the standard support page to be green when the client requests / can request batch (and handle messages in batches without dropping them or similar), and to create a similar batch-types support page similar to the SASL mechs support page, detailing exactly which batches are supported.

The above is what I'll be going by for the future, and I'll make that batch types support page sometime soon.

@DarthGandalf
Copy link
Member

To clarify: are you talking about the spec, or about support tables?
Spec is vague by design, to allow clients make use of batches as they see fit.
Regarding the support tables, I agree, it would be useful to know how exactly each client handles batches.

@prawnsalad
Copy link
Contributor

Echoing @DarthGandalf, clients may want to handle batches in their own way.

However, as long as a client can request + handle batch commands then they they do support batch. If a client has no need to send batch requests then the support pages showing this may come across as penalising in comparison to others for no good reason.

@SadieCat
Copy link
Contributor

SadieCat commented Nov 9, 2017

IMO supporting batch shouldn't involve supporting any particular batch type. It should just be requesting and supporting the infrastructure for receiving and handling batches.

We can have a separate support table for specific batch types.

@DanielOaks
Copy link
Member Author

DanielOaks commented Nov 9, 2017

Coolcool, in that case we're all pretty much on the same page, can just keep doing this in the future. I'll leave this issue open 'til #45 is resolved and add a note somewhere so we know this going forward.

edit: @DarthGandalf just the support tables yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants