Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename iree-hip- compiler flags to iree-rocm- when they apply to codegen. #18792

Open
benvanik opened this issue Oct 16, 2024 · 3 comments
Open

Rename iree-hip- compiler flags to iree-rocm- when they apply to codegen. #18792

benvanik opened this issue Oct 16, 2024 · 3 comments
Labels
cleanup 🧹 codegen/rocm ROCm code generation compiler backend (HIP/HSA)

Comments

@benvanik
Copy link
Collaborator

The various ROCM codegen flags like iree-hip-target and iree-hip-enable-ukernels are not HIP-specific and need to be renamed back to ROCM. The AMDGPU target uses the same ROCM codegen and we shouldn't have any hip naming in the shared code paths.
@benvanik benvanik added cleanup 🧹 codegen/rocm ROCm code generation compiler backend (HIP/HSA) labels Oct 16, 2024
@ScottTodd
Copy link
Member

Can we alias the flags? Changing the flag names once caused some disruption.

@qedawkins
Copy link
Contributor

My vote would be for llvm-amdgpu or maybe just amdgpu (but that might be unclear w.r.t. SPIRV) so that it's clear that we're using LLVM's amdgpu backend.

@benvanik
Copy link
Collaborator Author

llvm-amdgpu sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup 🧹 codegen/rocm ROCm code generation compiler backend (HIP/HSA)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benvanik @ScottTodd @qedawkins